fix(alerts): better message for missing target ID #79737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: src/sentry/incidents/serializers/alert_rule_trigger.py
Did you find this useful? React with a 👍 or 👎 |
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #79737 +/- ##
==========================================
- Coverage 78.45% 78.45% -0.01%
==========================================
Files 7144 7140 -4
Lines 315931 315939 +8
Branches 43472 43477 +5
==========================================
- Hits 247869 247863 -6
- Misses 61736 61746 +10
- Partials 6326 6330 +4 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
target_identifieris required by the alert rule trigger action serializer. Previously, if this field was left blank, then the serializer would return the default "this field may not be blank" error message. Surface a more descriptive message to the user instead.Fixes https://github.com/getsentry/team-core-product-foundations/issues/155